[webkit-reviews] review granted: [Bug 207898] Add an os_log PrintStream : [Attachment 391077] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 13:15:16 PST 2020


Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 207898: Add an os_log PrintStream
https://bugs.webkit.org/show_bug.cgi?id=207898

Attachment 391077: Patch

https://bugs.webkit.org/attachment.cgi?id=391077&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 391077
  --> https://bugs.webkit.org/attachment.cgi?id=391077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391077&action=review

r=me with JSC options added.

> Source/JavaScriptCore/jsc.cpp:2941
> +#if OS(DARWIN)
> +	       setDataFile(OSLogPrintStream::open("com.apple.JavaScriptCore",
"DataLog", OS_LOG_TYPE_INFO));
> +#else

Please add a JSC option to invoke this so that we can also enable this os
logging for the WebProcess, or whatever process is using JSC.


More information about the webkit-reviews mailing list