[webkit-reviews] review granted: [Bug 207828] AX: Adopt _AXSCopyPathForAccessibilityBundle for WebKit : [Attachment 390892] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Liang <ericliang at apple.com>'s
request for review:
Bug 207828: AX: Adopt _AXSCopyPathForAccessibilityBundle for WebKit
https://bugs.webkit.org/show_bug.cgi?id=207828

Attachment 390892: Patch

https://bugs.webkit.org/attachment.cgi?id=390892&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 390892
  --> https://bugs.webkit.org/attachment.cgi?id=390892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390892&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:411
> +    return (__bridge_transfer NSString
*)_AXSCopyPathForAccessibilityBundle(CFSTR("WebProcessLoader"));

In my obsession with encouraging you to keep using the old function, I missed
something more important. This file is not compiled with ARC, and in this case
I suspect __bridge_transfer is not going to do the right thing. We need
something that will compile into a call to autorelease; I think a call to
CFAutorelease.

I’m going to say review+ but please don’t land this if it’s leaking the string.
I don’t think __bridge_transfer actually correctly causes the autorelease
needed in non-ARC code.