[webkit-reviews] review granted: [Bug 207879] [LFC][TreeBuilding] Take createLineBreakBox's return value : [Attachment 391027] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 02:45:09 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 207879: [LFC][TreeBuilding] Take createLineBreakBox's return value
https://bugs.webkit.org/show_bug.cgi?id=207879

Attachment 391027: Patch

https://bugs.webkit.org/attachment.cgi?id=391027&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 391027
  --> https://bugs.webkit.org/attachment.cgi?id=391027
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391027&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216
> -	      
createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(),
WTFMove(clonedStyle));
> +	       childLayoutBox =
&createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(),
WTFMove(clonedStyle));

lol


More information about the webkit-reviews mailing list