[webkit-reviews] review granted: [Bug 207852] [css-grid] Improve performance of track sizing algorithm for spanning items : [Attachment 390984] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 207852: [css-grid] Improve performance of track sizing algorithm for
spanning items
https://bugs.webkit.org/show_bug.cgi?id=207852

Attachment 390984: Patch

https://bugs.webkit.org/attachment.cgi?id=390984&action=review




--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 390984
  --> https://bugs.webkit.org/attachment.cgi?id=390984
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390984&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:247
> +    const GridTrackSize& trackSize =
tracks(m_direction)[trackPosition].cachedTrackSize();

We can use 'auto' type here.

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:271
> +	   const GridTrackSize& trackSize =
trackList[trackPosition].cachedTrackSize();

Ditto

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:450
> +	       const GridTrackSize& trackSize = track.cachedTrackSize();

Ditto

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:573
> +	   // We cannot use tracks(direction)[trackPosition].cachedTrackSize()

It's not needed to wrap comments like this.

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:634
> +	   const GridTrackSize& trackSize = rawGridTrackSize(direction,
trackPosition);

Use auto here

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:729
> +	   const GridTrackSize& trackSize =
allTracks[trackIndex].cachedTrackSize();

Ditto

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:825
> +	       const GridTrackSize& trackSize =
allTracks[trackPosition].cachedTrackSize();

Ditto