[webkit-reviews] review granted: [Bug 207870] Move from "layer flush" terminology to "rendering update" : [Attachment 391002] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 207870: Move from "layer flush" terminology to "rendering update"
https://bugs.webkit.org/show_bug.cgi?id=207870

Attachment 391002: Patch

https://bugs.webkit.org/attachment.cgi?id=391002&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 391002
  --> https://bugs.webkit.org/attachment.cgi?id=391002
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391002&action=review

> Source/WebCore/page/ChromeClient.h:342
> +    virtual bool
adjustRenderUpdateThrottling(OptionSet<RenderingUpdateThrottleState>) { return
false; }

should this be an -ing?

>
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:1
59
> +    bool m_nextRenderingUpdateIsImmediate { false };

If we're changing the name, can we change it to something less mysterious?