[webkit-reviews] review granted: [Bug 207868] ASSERT_NOT_REACHED() under WebPageProxy::suspendCurrentPageIfPossible() : [Attachment 391001] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 207868: ASSERT_NOT_REACHED() under
WebPageProxy::suspendCurrentPageIfPossible()
https://bugs.webkit.org/show_bug.cgi?id=207868

Attachment 391001: Patch

https://bugs.webkit.org/attachment.cgi?id=391001&action=review




--- Comment #3 from John Wilander <wilander at apple.com> ---
Comment on attachment 391001
  --> https://bugs.webkit.org/attachment.cgi?id=391001
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391001&action=review

See the one comment.

> Source/WebCore/loader/HistoryController.cpp:554
> +    bool needsPrivacy = page->usesEphemeralSession();

Privacy is such a broad term. I'd prefer to stick with ephemeral as the term
because that's the only privacy promise it makes. Would isEphemeral work? Or
just usesEphemeralSession?