[webkit-reviews] review granted: [Bug 207789] Ensure that contenteditable carets on MacCatalyst are the right color, especially in Dark Mode : [Attachment 390994] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 207789: Ensure that contenteditable carets on MacCatalyst are the right
color, especially in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=207789

Attachment 390994: Patch

https://bugs.webkit.org/attachment.cgi?id=390994&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390994
  --> https://bugs.webkit.org/attachment.cgi?id=390994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390994&action=review

> Source/WebCore/ChangeLog:3
> +	   Fix contenteditable carets on MacCatalyst

oO oO oO oO Please put the new title here.

> Source/WebKit/ChangeLog:9
> +	   Because UIKit only uses label color for the caret in MacCatlayst, 

macCatalyst

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3221
> +    // On macCatalyst we need to explicitly return the color we have
calculated, rather than rely on textTraits, as on macCatalyst, UIKit ignores
text traits, and relies on AppKit's calulation, which cannot track dark mode
correctly in web content.

calulation

Also, this part isn't about dark mode... they totally ignore ANY
insertionPointColor change, even from caretColor. I would just stop after
"ignores text traits" and slap a period on there and you're golden.