[webkit-reviews] review granted: [Bug 207686] [WPE] Add support for rendering spin buttons : [Attachment 390626] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 207686: [WPE] Add support for rendering spin buttons
https://bugs.webkit.org/show_bug.cgi?id=207686

Attachment 390626: Patch

https://bugs.webkit.org/attachment.cgi?id=390626&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390626
  --> https://bugs.webkit.org/attachment.cgi?id=390626
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390626&action=review

r+, but please check the comment below before landing.

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:50
> +static const unsigned menuListButtonArrowSize = 16;

Does this need to have the same value as “arrowSize“ in ThemeWPE.cpp?
If yes, please add a comment here saying so.

> Source/WebCore/platform/wpe/ThemeWPE.cpp:40
> +static const unsigned arrowSize = 16;

If this needs to have the same size as “menuListButtonArrowSize” in
RenderThemeWPE.cpp, please add a comment indicating that.