[webkit-reviews] review granted: [Bug 207688] [WPE] Add support for rendering progress bars : [Attachment 390630] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 207688: [WPE] Add support for rendering progress bars
https://bugs.webkit.org/show_bug.cgi?id=207688

Attachment 390630: Patch

https://bugs.webkit.org/attachment.cgi?id=390630&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390630
  --> https://bugs.webkit.org/attachment.cgi?id=390630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390630&action=review

Just one small nit :]

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263
> +	   fieldRect.setWidth(std::max<float>(2, fieldRect.width() /
progressActivityBlocks));

Isn't two pixels a tad too narrow? Maybe it would make sense to
make it slightly wider, I think something around 5 to 6px would
be good.