[webkit-reviews] review granted: [Bug 206621] Make ImageBuffer::getImageData() and putImageData() return and take ImageData : [Attachment 390978] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 206621: Make ImageBuffer::getImageData() and putImageData() return and take
ImageData
https://bugs.webkit.org/show_bug.cgi?id=206621

Attachment 390978: Patch

https://bugs.webkit.org/attachment.cgi?id=390978&action=review




--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 390978
  --> https://bugs.webkit.org/attachment.cgi?id=390978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390978&action=review

> Source/WebCore/platform/graphics/ImageBuffer.h:118
> +    void draw(GraphicsContext&, const FloatRect& destRect, const FloatRect&
srcRect = FloatRect(0, 0, -1, -1), const ImagePaintingOptions& = { });

What is the magic 0, 0, -1, -1? Can we pass on Optional<FloatRect> instead?

Not new in this patch; can fix later

> Source/WebCore/platform/graphics/ImageBuffer.h:125
> +    static void drawConsuming(std::unique_ptr<ImageBuffer>,
GraphicsContext&, const FloatRect& destRect, const FloatRect& srcRect =
FloatRect(0, 0, -1, -1), const ImagePaintingOptions& = { });

Ditto.