[webkit-reviews] review granted: [Bug 207849] [Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register : [Attachment 390944] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 207849: [Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory
size register
https://bugs.webkit.org/show_bug.cgi?id=207849

Attachment 390944: Patch

https://bugs.webkit.org/attachment.cgi?id=390944&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 390944
  --> https://bugs.webkit.org/attachment.cgi?id=390944
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390944&action=review

r=me

>> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:165
>> +	return
Wasm::PinnedRegisterInfo::get().toSave(Wasm::MemoryMode::BoundsChecking);
> 
> When would we ever not want to save the sizeRegister?  Why not get rid of the
memoryMode condition and always save the register?  From gripping the code, I
don't see a case where toSave() is ever called with anything other than
MemoryMode::BoundsChecking.

I'm wrong, there's still one place where we may not pass
MemoryMode::BoundsChecking.