[webkit-reviews] review granted: [Bug 207587] Web Inspector: Update resource, type, and instrument icons for light, dark, and override colors : [Attachment 390955] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 207587: Web Inspector: Update resource, type, and instrument icons for
light, dark, and override colors
https://bugs.webkit.org/show_bug.cgi?id=207587

Attachment 390955: Patch

https://bugs.webkit.org/attachment.cgi?id=390955&action=review




--- Comment #22 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 390955
  --> https://bugs.webkit.org/attachment.cgi?id=390955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390955&action=review

I like the full color resource icons for overrides! I don’t think the dog ear
needs to be orange then. Just match the file color and shade it instead? Or
have it be light (dark) as if ony the front of the paper is colored.

> Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:9
> +	       }
> +	       .dark {

Found one!