[webkit-reviews] review denied: [Bug 207795] Stop using QTKit for rendering WK1 video fullscreen controls : [Attachment 390931] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 207795: Stop using QTKit for rendering WK1 video fullscreen controls
https://bugs.webkit.org/show_bug.cgi?id=207795

Attachment 390931: Patch

https://bugs.webkit.org/attachment.cgi?id=390931&action=review




--- Comment #5 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 390931
  --> https://bugs.webkit.org/attachment.cgi?id=390931
Patch

Seems to break the build:

iOS:
PAL/pal/spi/cocoa/AVKitSPI.h:33:33: error: cannot find interface declaration
for 'UIResponder', superclass of 'AVPlayerController'
https://ews-build.webkit.org/#/builders/23/builds/10800/steps/7/logs/errors

macOS:
clang: error: no such file or directory:
'/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WebKitLegacy/
mac/WebView/WebVideoFullscreenHUDWindowController.mm'
https://ews-build.webkit.org/#/builders/33/builds/3067/steps/7/logs/errors