[webkit-reviews] review granted: [Bug 207832] [LFC][Out-of-flow] FormattingContext::computeOutOfFlowHorizontalGeometry needs verticalConstraints : [Attachment 390898] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted zalan <zalan at apple.com>'s request for
review:
Bug 207832: [LFC][Out-of-flow]
FormattingContext::computeOutOfFlowHorizontalGeometry needs verticalConstraints
https://bugs.webkit.org/show_bug.cgi?id=207832

Attachment 390898: Patch

https://bugs.webkit.org/attachment.cgi?id=390898&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 390898
  --> https://bugs.webkit.org/attachment.cgi?id=390898
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390898&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286
> +	   contentWidthAndMargin =
geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox),
horizontalConstraints, { }, usedWidth);

Shouldn't the {}s be nullopts?