[webkit-reviews] review granted: [Bug 207471] [WPE] Use custom theme style to render buttons : [Attachment 390256] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 207471: [WPE] Use custom theme style to render buttons
https://bugs.webkit.org/show_bug.cgi?id=207471

Attachment 390256: Patch

https://bugs.webkit.org/attachment.cgi?id=390256&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390256
  --> https://bugs.webkit.org/attachment.cgi?id=390256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390256&action=review

I left just a small comment, otherwise LGTM :)

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:54
> +static const int menuListButtonBorderSize = 1; // Keep in sync with
buttonBorderSize in Theme.

I would also add a similar comment inside “ThemeWPE.cpp” warning
“Keep in sync with menuListButtonBorderSize in RenderTheme” so no
matter which file one is editing, there's always a note to ensure
that the other one is kept in sync =)