[webkit-reviews] review granted: [Bug 207803] Do not send the client URL to network process when unregistering a service worker registration : [Attachment 390850] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 207803: Do not send the client URL to network process when unregistering a
service worker registration
https://bugs.webkit.org/show_bug.cgi?id=207803

Attachment 390850: Patch

https://bugs.webkit.org/attachment.cgi?id=390850&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 390850
  --> https://bugs.webkit.org/attachment.cgi?id=390850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390850&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:296
> +	   auto iterator = m_clientOrigins.find(clientIdentifier);
> +	   if (iterator != m_clientOrigins.end())
> +	       clientData =
server().serviceWorkerClientWithOriginByID(iterator->value, clientIdentifier);
> +	   if (!clientData)
> +	       return { };

I think this would read better like this:

    auto iterator = m_clientOrigins.find(clientIdentifier);
    if (iterator == m_clientOrigins.end())
	return { };
    auto clientData =
server().serviceWorkerClientWithOriginByID(iterator->value, clientIdentifier);
    if (!clientData)
	return { };