[webkit-reviews] review granted: [Bug 203214] Mach lookup to com.apple.webinspector should not be allowed in WebKit's WebContent process : [Attachment 390657] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 203214: Mach lookup to com.apple.webinspector should not be allowed in
WebKit's WebContent process
https://bugs.webkit.org/show_bug.cgi?id=203214

Attachment 390657: Patch

https://bugs.webkit.org/attachment.cgi?id=390657&action=review




--- Comment #33 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 390657
  --> https://bugs.webkit.org/attachment.cgi?id=390657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390657&action=review

Thank you for reviewing it again. r=me

>> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:574
>> +   
CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(),
this, remoteWebInspectorEnabledCallback,
static_cast<CFStringRef>(CFSTR(WIRServiceEnabledNotification)), nullptr,
CFNotificationSuspensionBehaviorCoalesce);
> 
> Do we not need this for macOS?

Oh -- I see, you already answered this. Never mind.

>> Source/WebKit/WebProcess/WebProcess.cpp:436
>> +	Inspector::RemoteInspector::setNeedMachSandboxExtension(true);
> 
> Why isn't this needed on macOS, too? And what about MacCatalyst?

Never mind!