[webkit-reviews] review granted: [Bug 203420] Use CF prefs direct mode in the WebContent process : [Attachment 390601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 16 20:12:31 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 203420: Use CF prefs direct mode in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=203420

Attachment 390601: Patch

https://bugs.webkit.org/attachment.cgi?id=390601&action=review




--- Comment #30 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 390601
  --> https://bugs.webkit.org/attachment.cgi?id=390601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390601&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:90
> +    std::initializer_list<NSString*> domains = {

Do we have a way to identify other domains we will need to access if some are
missing from this list?


More information about the webkit-reviews mailing list