[webkit-reviews] review granted: [Bug 207404] Ephemeral session data leaks between processes : [Attachment 390702] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 207404: Ephemeral session data leaks between processes
https://bugs.webkit.org/show_bug.cgi?id=207404

Attachment 390702: Patch

https://bugs.webkit.org/attachment.cgi?id=390702&action=review




--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 390702
  --> https://bugs.webkit.org/attachment.cgi?id=390702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390702&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:514
> +    RetainPtr<CFStringRef> cfIdentifier = makeString(identifierBase,
".PrivateBrowsing.", createCanonicalUUIDString()).createCFString();

Why not just use a UUID? Is it important to include the identifier and the word
“PrivateBrowsing”? Is that used in debugging or something?

> Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp:89
> +    RetainPtr<CFStringRef> cfIdentifier = makeString(identifierBase,
".PrivateBrowsing.", createCanonicalUUIDString()).createCFString();

Ditto.