[webkit-reviews] review denied: [Bug 204320] Move [UIDevice currentDevice] calls to UI process : [Attachment 390787] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 204320: Move [UIDevice currentDevice] calls to UI process
https://bugs.webkit.org/show_bug.cgi?id=204320

Attachment 390787: Patch

https://bugs.webkit.org/attachment.cgi?id=390787&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 390787
  --> https://bugs.webkit.org/attachment.cgi?id=390787
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390787&action=review

Looks great, but one significant problem.

> Source/WebCore/platform/ios/LocalizedDeviceModel.mm:47
> +    auto localizedDeviceModel = retainPtr([[PAL::getUIDeviceClass()
currentDevice] localizedModel]);

This isn’t setting cachedLocalizedDeviceModel, and it should be setting it.
Unless our intent is to never cache it?

There should be no need to explicitly call retainPtr. It’s almost never
something you have to call explicitly.