[webkit-reviews] review granted: [Bug 207794] Add WebInspector support to WebKit::WebSocketChannel : [Attachment 390845] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 207794: Add WebInspector support to WebKit::WebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=207794

Attachment 390845: Patch

https://bugs.webkit.org/attachment.cgi?id=390845&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 390845
  --> https://bugs.webkit.org/attachment.cgi?id=390845
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390845&action=review

> Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50
> +    unsigned long m_progressIdentifier { 0 };

The use of “long” here seems questionable. An unsigned is already 32 bits, just
like an unsigned long.

> Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53
> +    WebSocketFrame frame(opCode, true, false, true, data, length);

Sure seems mysterious, written like this.