[webkit-reviews] review granted: [Bug 191532] ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects : [Attachment 390870] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jack <shihchieh_lee at apple.com>'s
request for review:
Bug 191532: ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in
WebCore::FrameView::updateEmbeddedObjects
https://bugs.webkit.org/show_bug.cgi?id=191532

Attachment 390870: Patch

https://bugs.webkit.org/attachment.cgi?id=390870&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 390870
  --> https://bugs.webkit.org/attachment.cgi?id=390870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390870&action=review

> Source/WebCore/html/HTMLEmbedElement.cpp:84
> +    if (!view || (!view->inUpdateEmbeddedObjects() &&
!view->layoutContext().isInLayout() && !view->isPainting())) {

Can we put a helper function somewhere so we don’t need to repeat this logic in
both HTMLEmbedElement and HTMLObjectElement?