[webkit-reviews] review granted: [Bug 207789] Fix contenteditable carets on MacCatalyst : [Attachment 390816] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 207789: Fix contenteditable carets on MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=207789

Attachment 390816: Patch

https://bugs.webkit.org/attachment.cgi?id=390816&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390816
  --> https://bugs.webkit.org/attachment.cgi?id=390816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390816&action=review

> Source/WebCore/editing/FrameSelection.cpp:1802
>      if (element && element->renderer()) {

Remove the extraneous curly braces

> Source/WebCore/editing/FrameSelection.cpp:1803
> +	   caretColor =
CaretBase::computeCaretColor(element->renderer()->style());

You don't pass a node here? Also, maybe just pass the element and have
computeCaretColor find what it wants?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3222
> +    return [self getInteractionTintColor];

This isn't how we use the `get` prefix. I would go with
`_interactionTintColor`.