[webkit-reviews] review granted: [Bug 207587] Web Inspector: Update resource, type, and instrument icons for light, dark, and override colors : [Attachment 390769] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 207587: Web Inspector: Update resource, type, and instrument icons for
light, dark, and override colors
https://bugs.webkit.org/show_bug.cgi?id=207587

Attachment 390769: Patch

https://bugs.webkit.org/attachment.cgi?id=390769&action=review




--- Comment #17 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 390769
  --> https://bugs.webkit.org/attachment.cgi?id=390769
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390769&action=review

Looking great! Just some minor style issues and one case of visibility.

> Source/WebInspectorUI/UserInterface/Images/Database.svg:7
> +	       g { visibility: hidden; }
> +	       g:target { visibility: visible; }

Old approach still in this file.

> Source/WebInspectorUI/UserInterface/Images/Database.svg:13
> +	       }
> +	       #dark {

Also needs line breaks.

> Source/WebInspectorUI/UserInterface/Images/DocumentIcons.svg:6
> +	   <style>
> +	   g:not(:target) {

Style rules not indented like the rest of the images.

> Source/WebInspectorUI/UserInterface/Images/FolderGeneric.svg:6
> +	   <style>
> +	     g:not(:target) {

Wrong indentation here.

> Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:4
> +<svg xmlns="http://www.w3.org/2000/svg" version="1.1">
> +<defs>

Not indented at a second level like the rest.

> Source/WebInspectorUI/UserInterface/Images/InstrumentIcons.svg:9
> +	   }
> +	   .dark {

Add line break.

> Source/WebInspectorUI/UserInterface/Images/Stopwatch.svg:9
> +	       }
> +	       #light {

Line break.

> Source/WebInspectorUI/UserInterface/Images/Stopwatch.svg:14
> +	       }
> +	       #dark {

Ditto.

> Source/WebInspectorUI/UserInterface/Images/TypeIcons.svg:6
> +	   <style>
> +	   g:not(:target) {

Indentation.