[webkit-reviews] review granted: [Bug 207664] WebKit support for Apple Pay Buttons with custom corner radii : [Attachment 390779] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 14 11:52:37 PST 2020
Andy Estes <aestes at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 207664: WebKit support for Apple Pay Buttons with custom corner radii
https://bugs.webkit.org/show_bug.cgi?id=207664
Attachment 390779: Patch
https://bugs.webkit.org/attachment.cgi?id=390779&action=review
--- Comment #6 from Andy Estes <aestes at apple.com> ---
Comment on attachment 390779
--> https://bugs.webkit.org/attachment.cgi?id=390779
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=390779&action=review
One last comment, but otherwise the patch looks great. You can upload a new
patch with my named filled in to the "Reviewed by" lines in the ChangeLog. You
don't need to set the review bit, but if you set the cq? bit I'll cq+ it.
Thanks Nikos!
> LayoutTests/http/tests/ssl/applepay/ApplePayButton.html:55
> + if((type == "plain" || type == "set-up")){
Why only these two types?
More information about the webkit-reviews
mailing list