[webkit-reviews] review granted: [Bug 207450] [Curl] Implement NetworkStorageSession::get/set/deleteCookie : [Attachment 390785] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 207450: [Curl] Implement NetworkStorageSession::get/set/deleteCookie
https://bugs.webkit.org/show_bug.cgi?id=207450

Attachment 390785: Patch

https://bugs.webkit.org/attachment.cgi?id=390785&action=review




--- Comment #11 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 390785
  --> https://bugs.webkit.org/attachment.cgi?id=390785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390785&action=review

Fix the ":memory:"_s and we're good.

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:467
> +	   Cookie cookie;
> +	   cookie.name = pstmt->getColumnText(0);
> +	   cookie.value = pstmt->getColumnText(1);
> +	   cookie.domain = pstmt->getColumnText(2).convertToASCIILowercase();
> +	   cookie.path = pstmt->getColumnText(3);
> +	   cookie.expires = (double)pstmt->getColumnInt64(4) * 1000;
> +	   cookie.httpOnly = (pstmt->getColumnInt(5) == 1);
> +	   cookie.secure = (pstmt->getColumnInt(6) == 1);
> +	   cookie.session = (pstmt->getColumnInt(7) == 1);

I think this is something we can do in a follow up but I'm just making a note
that this is probably something we'd want to do in a local function since I see
this code elsewhere in the file.

> Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:66
> +    , m_cookieDatabase(makeUniqueRef<CookieJarDB>(sessionID.isEphemeral() ?
":memory:" : defaultCookieJarPath()))

Missed the ":memory:"_s here