[webkit-reviews] review granted: [Bug 207760] [Web Animations] Use running animations unanimated style when considering new CSS Transitions : [Attachment 390767] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 207760: [Web Animations] Use running animations unanimated style when
considering new CSS Transitions
https://bugs.webkit.org/show_bug.cgi?id=207760

Attachment 390767: Patch

https://bugs.webkit.org/attachment.cgi?id=390767&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 390767
  --> https://bugs.webkit.org/attachment.cgi?id=390767
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390767&action=review

> LayoutTests/ChangeLog:3
> +	   [Web Animations] Use running animations unanimated style when
considering new CSS Transitions

Should this be "Use running animation's unanimated style when considering new
CSS Transitions"? It's a bit hard to parse.

I think it's more like "Style changes due to Web Animations should not trigger
transitions".

> Source/WebCore/animation/KeyframeEffect.cpp:786
> +bool KeyframeEffect::animatesProperty(CSSPropertyID property) const
> +{
> +    if (!m_blendingKeyframes.isEmpty())
> +	   return m_blendingKeyframes.properties().contains(property);
> +
> +    for (auto& keyframe : m_parsedKeyframes) {
> +	   for (auto keyframeProperty : keyframe.unparsedStyle.keys()) {
> +	       if (keyframeProperty == property)
> +		   return true;
> +	   }
> +    }
> +    return false;
> +}

I wonder if this will become a perf bottleneck. People do make keyframe
animations with hundreds of keyframes.