[webkit-reviews] review granted: [Bug 207629] [Web Animations] Make all animation event types inherit from the same base class : [Attachment 390754] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 207629: [Web Animations] Make all animation event types inherit from the
same base class
https://bugs.webkit.org/show_bug.cgi?id=207629

Attachment 390754: Patch

https://bugs.webkit.org/attachment.cgi?id=390754&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 390754
  --> https://bugs.webkit.org/attachment.cgi?id=390754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390754&action=review

very nice

> Source/WebCore/animation/CSSAnimation.h:52
> +    Ref<AnimationEventBase> createEvent(const AtomString& eventType, double
elapsedTime, const String& pseudoId, Optional<Seconds> timelineTime) final;

Maybe a comment somewhere to mention how elapsedTime and timelineTime differ.