[webkit-reviews] review granted: [Bug 207379] [WPE] Use custom theme style to render text fields : [Attachment 390069] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 207379: [WPE] Use custom theme style to render text fields
https://bugs.webkit.org/show_bug.cgi?id=207379

Attachment 390069: Patch

https://bugs.webkit.org/attachment.cgi?id=390069&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390069
  --> https://bugs.webkit.org/attachment.cgi?id=390069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review

Patch LGTM with a small unimportant nit :]

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43
> +static const int textFieldBorderSize = 1;

Nit: I would use “unsigned” here, as it does not make sense to allow
negative values for a border.