[webkit-reviews] review granted: [Bug 187984] [Curl] Use shared single thread for WebSocket connections : [Attachment 390619] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 187984: [Curl] Use shared single thread for WebSocket connections
https://bugs.webkit.org/show_bug.cgi?id=187984

Attachment 390619: Patch

https://bugs.webkit.org/attachment.cgi?id=390619&action=review




--- Comment #37 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 390619
  --> https://bugs.webkit.org/attachment.cgi?id=390619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390619&action=review

> Source/WebCore/platform/network/curl/CurlStream.cpp:161
> +    auto& sendBuffer = m_sendBuffers.first();

auto& [buffer, length] = m_sendBuffers.first();

> Source/WebCore/platform/network/curl/CurlStream.cpp:188
> +	   client.didFail(streamID, errorCode, WTFMove(url));

Remove url of didFail becasue SocketStreamHandleImpl knows own m_url.
m_url.isolatedCopy() is redundant.