[webkit-reviews] review denied: [Bug 207727] [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention. : [Attachment 390699] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 17:30:24 PST 2020


Mark Lam <mark.lam at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 207727: [WASM] Wasm interpreter's calling convention doesn't match Wasm
JIT's convention.
https://bugs.webkit.org/show_bug.cgi?id=207727

Attachment 390699: Patch

https://bugs.webkit.org/attachment.cgi?id=390699&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 390699
  --> https://bugs.webkit.org/attachment.cgi?id=390699
Patch

The preservation and restoration of callee saved registers with this patch
(when calling from JS to wasm or wasm to wasm) is broken.  Tadeu's working on a
fix.


More information about the webkit-reviews mailing list