[webkit-reviews] review denied: [Bug 207676] Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting : [Attachment 390620] Fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 13 15:16:55 PST 2020
Timothy Hatcher <timothy at apple.com> has denied review:
Bug 207676: Dark Mode: In Notes, list item becomes invisible in dark mode after
outdenting
https://bugs.webkit.org/show_bug.cgi?id=207676
Attachment 390620: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=390620&action=review
--- Comment #6 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 390620
--> https://bugs.webkit.org/attachment.cgi?id=390620
Fixes the bug
View in context: https://bugs.webkit.org/attachment.cgi?id=390620&action=review
> Source/WebCore/editing/EditingStyle.cpp:1385
> + m_mutableStyle->setProperty(CSSPropertyColor, computedValue);
This should use id, otherwise CSSPropertyBackgroundColor and
CSSPropertyCaretColor will overwrite CSSPropertyColor.
More information about the webkit-reviews
mailing list