[webkit-reviews] review granted: [Bug 207717] iOS: Autoscrolling is too fast and way too aggressive : [Attachment 390682] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 207717: iOS: Autoscrolling is too fast and way too aggressive
https://bugs.webkit.org/show_bug.cgi?id=207717

Attachment 390682: Patch

https://bugs.webkit.org/attachment.cgi?id=390682&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 390682
  --> https://bugs.webkit.org/attachment.cgi?id=390682
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390682&action=review

I am saddened by the lack of tests.

> Source/WebCore/page/EventHandler.h:631
>      bool m_isAutoscrolling { false };

Please move this bool up.

> Source/WebCore/page/ios/EventHandlerIOS.mm:627
> +	   if (autoscrollDelta.height() < insetDistanceThreshold)

Blank line above please.

> Source/WebCore/page/ios/EventHandlerIOS.mm:637
> +	   float distanceFromEdge = autoscrollPoint.x() -
insetUnobscuredRootViewRect.x();

Do you want negative distanceFromEdge here?

> Source/WebCore/page/ios/EventHandlerIOS.mm:646
> +	   float distanceFromEdge = autoscrollPoint.y() -
insetUnobscuredRootViewRect.y();

Ditto.