[webkit-reviews] review granted: [Bug 207682] [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control : [Attachment 390623] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 207682: [Win][MiniBrowser] Reimplement the toolbar by using toolbar common
control
https://bugs.webkit.org/show_bug.cgi?id=207682

Attachment 390623: Patch

https://bugs.webkit.org/attachment.cgi?id=390623&action=review




--- Comment #5 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 390623
  --> https://bugs.webkit.org/attachment.cgi?id=390623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390623&action=review

Seems okay to me, though I think we're going to need some prettier icons, haha.
:)

> Tools/MiniBrowser/win/MainWindow.cpp:51
> +static constexpr int cToolbarImageSize = 24;
> +static constexpr int cToolbarURLBarIndex = 4;
> +static constexpr int cToolbarProgressIndicatorIndex = 6;

Do we have precedent for this `cFooBar` naming convention?

> Tools/MiniBrowser/win/MainWindow.h:80
> +    int m_toolbarItemsWidth { };

If you're going to put braces here, shouldn't it be `{ 0 }`?