[webkit-reviews] review granted: [Bug 205801] [GStreamer] Streaming aac/mp3 audio doesn't always work : [Attachment 390656] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 09:25:07 PST 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 205801: [GStreamer] Streaming aac/mp3 audio doesn't always work
https://bugs.webkit.org/show_bug.cgi?id=205801

Attachment 390656: Patch

https://bugs.webkit.org/attachment.cgi?id=390656&action=review




--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 390656
  --> https://bugs.webkit.org/attachment.cgi?id=390656
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390656&action=review

> LayoutTests/http/tests/media/video-no-content-length.html:22
> +	   testExpected("video.duration == Infinity", true);

shouldn't this be testExpected(video.duration, Infinity) ? That way the
expectation would make more sense.


More information about the webkit-reviews mailing list