[webkit-reviews] review granted: [Bug 207695] Rename SerializedPlatformRepresentation to SerializedPlatformDataCue : [Attachment 390647] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 207695: Rename SerializedPlatformRepresentation to
SerializedPlatformDataCue
https://bugs.webkit.org/show_bug.cgi?id=207695

Attachment 390647: Patch

https://bugs.webkit.org/attachment.cgi?id=390647&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 390647
  --> https://bugs.webkit.org/attachment.cgi?id=390647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390647&action=review

> Source/WebCore/html/track/DataCue.cpp:119
> +    const SerializedPlatformDataCue* otherPlatformValue =
dataCue->platformValue();

s/SerializedPlatformDataCue/auto/

> Source/WebCore/platform/SerializedPlatformDataCue.h:2
> + * Copyright (C) 2014 Apple Inc. All rights reserved.

2020?

> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:38
> +class SerializedPlatformDataCueMac : public SerializedPlatformDataCue {

final?

> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:46
> +    bool isEqual(const SerializedPlatformDataCue&) const override;

final here and above?

> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:53
> +    SerializedPlatformDataCueMac(id nativeValue);

explicit.