[webkit-reviews] review requested: [Bug 207691] [GStreamer][EME] Fix warnings in LOG_DISABLED build : [Attachment 390634] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 05:36:31 PST 2020


Charlie Turner <cturner at igalia.com> has asked  for review:
Bug 207691: [GStreamer][EME] Fix warnings in LOG_DISABLED build
https://bugs.webkit.org/show_bug.cgi?id=207691

Attachment 390634: Patch

https://bugs.webkit.org/attachment.cgi?id=390634&action=review




--- Comment #1 from Charlie Turner <cturner at igalia.com> ---
Created attachment 390634

  --> https://bugs.webkit.org/attachment.cgi?id=390634&action=review

Patch

Fix warnings with LOG_DISABLED. It would be nice if the LOG macro could arrange
for VA_ARGS to be UNUSED_VARIABLES when LOG_DISABLED, but I do not know how to
achieve this with preprocessor macros


More information about the webkit-reviews mailing list