[webkit-reviews] review granted: [Bug 207677] Add options for debugging WASM code. : [Attachment 390611] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 207677: Add options for debugging WASM code.
https://bugs.webkit.org/show_bug.cgi?id=207677

Attachment 390611: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=390611&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 390611
  --> https://bugs.webkit.org/attachment.cgi?id=390611
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=390611&action=review

r=me with one comment.

> Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:98
> +    if
(!Options::wasmFunctionIndexRangeToCompile().isInRange(codeBlock->functionIndex
()))

This functionIndex is per-wasm-module thing. If we have two wasm modules, they
can have the same function index for different functions.
Currently, I think this is OK. But maybe, should we introduce dfgWhitelist like
mechanism instead?