[webkit-reviews] review requested: [Bug 207673] [JSC] Compact JITCodeMap by storing BytecodeIndex and CodeLocation separately : [Attachment 390606] Patch

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has asked	for review:
Bug 207673: [JSC] Compact JITCodeMap by storing BytecodeIndex and CodeLocation
separately
https://bugs.webkit.org/show_bug.cgi?id=207673

Attachment 390606: Patch

https://bugs.webkit.org/attachment.cgi?id=390606&action=review




--- Comment #9 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 390606
  --> https://bugs.webkit.org/attachment.cgi?id=390606
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390606&action=review

> Source/JavaScriptCore/jit/JITCodeMap.h:46
> +	   m_pointer =
MallocPtr<uint8_t>::malloc(sizeof(CodeLocationLabel<JSEntryPtrTag>) * m_size +
sizeof(BytecodeIndex) * m_size);

Don't we need to insure some alignment minimum here ? (I would say
alignof(CodeLocationLabel<JSEntryPtrTag>)

> Source/JavaScriptCore/jit/JITCodeMap.h:56
> +	   return codeLocations()[index - indexes()];

I'm confused about this line. Can you explain why it is not just
codeLocations()[index] ?