[webkit-reviews] review granted: [Bug 207670] [LFC][IFC] Remove LineLayoutContext::m_partialTrailingTextItem : [Attachment 390584] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 12 16:36:36 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 207670: [LFC][IFC] Remove LineLayoutContext::m_partialTrailingTextItem
https://bugs.webkit.org/show_bug.cgi?id=207670

Attachment 390584: Patch

https://bugs.webkit.org/attachment.cgi?id=390584&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 390584
  --> https://bugs.webkit.org/attachment.cgi?id=390584
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390584&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85
>      Optional<InlineTextItem> m_partialLeadingTextItem;
> -    Optional<InlineTextItem> m_partialTrailingTextItem;

Why not both?


More information about the webkit-reviews mailing list