[webkit-reviews] review granted: [Bug 207601] Fix highlight text decorations to work with all decoration types and colors : [Attachment 390469] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 207601: Fix highlight text decorations to work with all decoration types
and colors
https://bugs.webkit.org/show_bug.cgi?id=207601

Attachment 390469: Patch

https://bugs.webkit.org/attachment.cgi?id=390469&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 390469
  --> https://bugs.webkit.org/attachment.cgi?id=390469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> Source/WebCore/ChangeLog:11
> +	   Extended
http/wpt/css/css-highlight-api/highlight-text-decorations.html.

What are our plans to contribute this back to WPT?

> Source/WebCore/rendering/TextDecorationPainter.cpp:377
> +    Color result =
style.visitedDependentColorWithColorFilter(CSSPropertyTextDecorationColor);

auto?