[webkit-reviews] review granted: [Bug 205770] new FontFace() should not throw when failing to parse arguments : [Attachment 390423] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 205770: new FontFace() should not throw when failing to parse arguments
https://bugs.webkit.org/show_bug.cgi?id=205770

Attachment 390423: Patch

https://bugs.webkit.org/attachment.cgi?id=390423&action=review




--- Comment #10 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 390423
  --> https://bugs.webkit.org/attachment.cgi?id=390423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390423&action=review

> Source/WebCore/css/CSSFontFace.cpp:728
> +    setStatus(Status::Failure);

What if it's already in the failure state? I don't think the state diagram has
loops in it.

> Source/WebCore/css/FontFace.cpp:374
> +	   return "U+0-10FFFF";

Shouldn't this be the empty string?

> Source/WebCore/css/FontFace.cpp:389
> +	   return "normal"_s;

Ditto.