[webkit-reviews] review granted: [Bug 207615] macCatalyst: Unable to grab scrollbar on editable text field : [Attachment 390493] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 207615: macCatalyst: Unable to grab scrollbar on editable text field
https://bugs.webkit.org/show_bug.cgi?id=207615

Attachment 390493: Patch

https://bugs.webkit.org/attachment.cgi?id=390493&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390493
  --> https://bugs.webkit.org/attachment.cgi?id=390493
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184
> +	   if ([NSStringFromClass(view.class)
isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview
isKindOfClass:WKChildScrollView.class]) {

NSStringFromClass every time is probably not a great plan. Maybe look up the
class from string once, keep it, and use isKindOfClass?

Or at least flip the conditions?