[webkit-reviews] review granted: [Bug 207587] Web Inspector: Update resource, type, and instrument icons for light, dark, and override colors : [Attachment 390430] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Jon Davis <jond at apple.com>'s request
for review:
Bug 207587: Web Inspector: Update resource, type, and instrument icons for
light, dark, and override colors
https://bugs.webkit.org/show_bug.cgi?id=207587

Attachment 390430: Patch

https://bugs.webkit.org/attachment.cgi?id=390430&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 390430
  --> https://bugs.webkit.org/attachment.cgi?id=390430
Patch

I only found one little error. This is a neat way to do a sprite sheet!

My only suggestion is that -dark be renamed to -light-theme and -light be
renamed to -dark-theme. If I were to inspect the Inspector, it would be
confusing to use Dark mode (eg. dark theme) and see icons labelled as -light. I
prefer the label to be of the corresponding theme (dark or light) rather than
the luma values of the image.

r=me