[webkit-reviews] review granted: [Bug 207582] WebPage::getFocusedElementInformation should be robust when the focused element changes during layout : [Attachment 390421] Speculative fix

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 207582: WebPage::getFocusedElementInformation should be robust when the
focused element changes during layout
https://bugs.webkit.org/show_bug.cgi?id=207582

Attachment 390421: Speculative fix

https://bugs.webkit.org/attachment.cgi?id=390421&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390421
  --> https://bugs.webkit.org/attachment.cgi?id=390421
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=390421&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2988
> +    auto focusedElement = m_focusedElement;

auto makes it impossible to tell if this retains the element or not. But it
needs to, right?