[webkit-reviews] review granted: [Bug 206888] [ESNext][BigInt] We don't support BigInt literal as PropertyName : [Attachment 390419] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 206888: [ESNext][BigInt] We don't support BigInt literal as PropertyName
https://bugs.webkit.org/show_bug.cgi?id=206888

Attachment 390419: Patch

https://bugs.webkit.org/attachment.cgi?id=390419&action=review




--- Comment #9 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 390419
  --> https://bugs.webkit.org/attachment.cgi?id=390419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390419&action=review

Hooray for tests finding bugs!

> Source/JavaScriptCore/parser/ParserArena.cpp:90
> +    // FIXME: We are allocating a JSBigInt just to be able to use
> +    // JSBigInt::tryGetString when radix is not 10.
> +    // This creates some GC pressure, but since these identifiers
> +    // will only be created when BigInt literal is used as a property name,
> +    // it wont be much problematic, given such cases are very rare.

Should this FIXME have a bug?