[webkit-reviews] review requested: [Bug 197684] [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData : [Attachment 390418] patch

[bugzilla-daemon at webkit.org]

Christopher Reid <chris.reid at sony.com> has asked  for review:
Bug 197684: [Win] Implement NetworkCache::Data by using
FileSystem::MappedFileData
https://bugs.webkit.org/show_bug.cgi?id=197684

Attachment 390418: patch

https://bugs.webkit.org/attachment.cgi?id=390418&action=review




--- Comment #15 from Christopher Reid <chris.reid at sony.com> ---
Created attachment 390418

  --> https://bugs.webkit.org/attachment.cgi?id=390418&action=review

patch

Updated patch addressing comments from Alex and Adrian.

I updated NetworkCacheDataCurl to use a ref counted Variant<Vector<uint8_t>,
FileSystem::MappedFileData> to act like the ref counted buffers for
mmap/allocated containers in Soup and Mac ports so the mapped file can be kept
around.

I'll be digging in to that GTK failure today.