[webkit-reviews] review granted: [Bug 206888] [ESNext][BigInt] We don't support BigInt literal as PropertyName : [Attachment 390368] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 206888: [ESNext][BigInt] We don't support BigInt literal as PropertyName
https://bugs.webkit.org/show_bug.cgi?id=206888

Attachment 390368: Patch

https://bugs.webkit.org/attachment.cgi?id=390368&action=review




--- Comment #5 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 390368
  --> https://bugs.webkit.org/attachment.cgi?id=390368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390368&action=review

r=me with comments.

Seems like Mozilla's tests also cover binary/octal/hex literals:
https://searchfox.org/mozilla-central/source/js/src/tests/non262/BigInt/propert
y-name.js
Do you think it's worth adding tests for these (maybe not necessary since
they're all just BIGINT tokens)?

> Source/JavaScriptCore/parser/Parser.cpp:4177
> +	   InferName inferName = ident && *ident ==
m_vm.propertyNames->underscoreProto ? InferName::Disallowed :
InferName::Allowed;

bigIntString can't be underscoreProto though, can it? Should this be an ASSERT?

> JSTests/ChangeLog:8
> +	   * stress/big-int-as-proeprty-name.js: Added.

Nit: spelling in filename :p