[webkit-reviews] review granted: [Bug 207547] [GStreamer][MSE] AV1 support : [Attachment 390366] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 207547: [GStreamer][MSE] AV1 support
https://bugs.webkit.org/show_bug.cgi?id=207547

Attachment 390366: Patch

https://bugs.webkit.org/attachment.cgi?id=390366&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 390366
  --> https://bugs.webkit.org/attachment.cgi?id=390366
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390366&action=review

You can have your patch sitting here as long as you want :) And it's r+ as
well.

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:87
> +	       GST_DEBUG("All elements for caps %" GST_PTR_FORMAT " are
blacklisted", caps.get());

Maybe warning?

> Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:211
> +    av1DecodersBlacklist.append(String("av1dec"));

I think you want to append unchecked here.