[webkit-reviews] review granted: [Bug 207352] Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes. : [Attachment 390303] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Alan Sien Wei Hshieh
<hshieh at apple.com>'s request for review:
Bug 207352: Add a variant of -[WKWebViewPrivate
_getContentsAsStringWithCompletionHandler:] that includes contents from
subframes.
https://bugs.webkit.org/show_bug.cgi?id=207352

Attachment 390303: Patch

https://bugs.webkit.org/attachment.cgi?id=390303&action=review




--- Comment #28 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 390303
  --> https://bugs.webkit.org/attachment.cgi?id=390303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390303&action=review

r=me

> Source/WebKit/Shared/ContentAsStringIncludesChildFrames.h:28
> +#include <wtf/EnumTraits.h>

Not needed.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3463
> +		       builder.append('\n');
> +		       builder.append('\n');

Are you sure you want two newlines?